Uploaded image for project: 'Website'
  1. Website
  2. WEBSITE-198

MODX Convertor Adds Legacy Spaces to Code

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • MOD validator
    • None

      Something else I've noticed from the MODX Convertor is that in the code sections (basically any section using a CDATA inside the <action-group></action-group> element), the MODX convertor adds an extra space right after the <![CDATA[ and right before the ]]>. The problem with this is that this gets added to the code to find, and therefore (since the Find box in text editors are so picky), will prevent the code from being found because of the extra spaces. This can, however, be fixed by removing the spaces, but this can become a tedious process on long MODs.

      I'll post a snippet of what I entered into the convertor and what was resulted; you'll see the extra spaces added:

      #
      #-----[ OPEN ]---------------------------------------------
      #
      common.php
      #
      #-----[ FIND ]---------------------------------------------
      #
      $board_config = array();
      #
      #-----[ AFTER, ADD ]---------------------------------------------
      #
      // MOD: Advanced Version Check
      $version_config = array();
      // END MOD: Advanced Version Check

      		<open src="common.php">
      			<edit>
      				<find><![CDATA[ $board_config = array(); ]]></find>
      				<action type="after-add"><![CDATA[ // MOD: Advanced Version Check
      $version_config = array();
      // END MOD: Advanced Version Check ]]></action>
      			</edit>

            wGEric Eric Faerber [X] (Inactive)
            webmacster87 Douglas Bell [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: