Uploaded image for project: 'Support Team Tools'
  1. Support Team Tools
  2. STT-130

wrong src assignment in style.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Invalid
    • Component/s: Other
    • Labels:
      None

      Description

      In line 255 of style.php
      I saw this statement:
      if (!isset($imgs[$img]))

      { $img_data = &$img_array[$img]; $imgsrc = ($img_data['image_lang'] ? $img_data['image_lang'] . '/' : '') . $img_data['image_filename']; $imgs[$img] = array( 'src' => $phpbb_root_path . 'styles/' . $theme['imageset_path'] . '/imageset/' . $imgsrc, 'width' => $img_data['image_width'], 'height' => $img_data['image_height'], ); }

      The 'src' assignment is wrong! It does point to the file on the server, and is not generating the url. The more important problem with this is, that it exposes the servers root path.
      This should be fixed by assigning a general available url_root or something like this.

        Attachments

          Activity

            People

            Assignee:
            A_Jelly_Doughnut A_Jelly_Doughnut
            Reporter:
            Mohs Mohs [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: