Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9823

Move functions definitions out of adm/index.php

          Details

          • Type: Improvement
          • Status: Unverified Fix
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 3.1.0-dev
          • Fix Version/s: 3.1.0-a1
          • Component/s: ACP
          • Labels:
            None

            Description

            Move functions defined in adm/index.php out to includes/functions_acp.php so they can be properly reused and unit tested.

              Issue Links

              caused

              Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-10557 Missing IN_PHPBB check in phpBB/includes/functions_acp.php

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Unverified Fix
              depends on

              Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10020 ACP function validate_range() fails partially on non-32-bit systems

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Unverified Fix

                Activity

                Hide
                Permalink
                nickvergessen Joas Schilling added a comment -

                Wrote tests for most of the functions.
                So far these are missing:

                validate_config_vars:

                • script_path
                • rpath
                • rwpath
                • path
                • wpath

                build_cfg_template:

                • select
                • custom

                As I don't really know, how to test them properly.
                If anyone wants to write them, feel free to do so.

                Show
                nickvergessen Joas Schilling added a comment - Wrote tests for most of the functions. So far these are missing: validate_config_vars: script_path rpath rwpath path wpath build_cfg_template: select custom As I don't really know, how to test them properly. If anyone wants to write them, feel free to do so.

                  People

                  • Assignee:
                    nickvergessen Joas Schilling
                    Reporter:
                    nickvergessen Joas Schilling
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development