Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9823

Move functions definitions out of adm/index.php

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: ACP
    • Labels:
      None

      Description

      Move functions defined in adm/index.php out to includes/functions_acp.php so they can be properly reused and unit tested.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          Wrote tests for most of the functions.
          So far these are missing:

          validate_config_vars:

          • script_path
          • rpath
          • rwpath
          • path
          • wpath

          build_cfg_template:

          • select
          • custom

          As I don't really know, how to test them properly.
          If anyone wants to write them, feel free to do so.

          Show
          nickvergessen Joas Schilling added a comment - Wrote tests for most of the functions. So far these are missing: validate_config_vars: script_path rpath rwpath path wpath build_cfg_template: select custom As I don't really know, how to test them properly. If anyone wants to write them, feel free to do so.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development