Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9630

Naming inconsistency of Merging Posts / Topics in MCP

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.7-PL1
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Language pack
    • Labels:
      None

      Description

      While working on the German translation, we came up with some problems with the merging of topics and posts.

      1. MERGE_POSTS is defined in both common.php and mcp.php
      The language variable "MERGE_POSTS" (Merge posts) is defined in common.php and in mcp.php. I don't see a reason why there should be both variables present.

      2. The terminology is confusing
      The quick-mod tools include two options "Merge posts" and "Merge topics". When calling the first of them (Merge posts), the secondary register in the MCP is titled "Merge topic". This is confusing to the user since "Merge topic" is a different action in the MCP.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          I read the discussion here and looked at UI with and without the patch.

          I agree that "Move Posts" is a more accurate description of the action than "Merge Posts". The fact that it is possible to figure out what "Merge Posts" really does does not detract from the fact that it is not an accurate label for the action.

          With that, my preferred solution would be to rename "Merge Posts" to "Move Posts" in quickmod tools and mcp (and anywhere else that action is referenced). This includes the "Merge topic"/"Merge posts" tab label changed by rxu's patch.

          If such a rename is not feasible for 3.0 I still suggest doing it for 3.1.

          I strongly prefer renaming the label to "Move Posts" but even only considering rxu's patch I think it is still an improvement over the current UI: "Merge topic" is an entirely different action from "Merge posts", as pointed out by the ticket's reporter. FWIW I agree with the reporter's original report also.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited I read the discussion here and looked at UI with and without the patch. I agree that "Move Posts" is a more accurate description of the action than "Merge Posts". The fact that it is possible to figure out what "Merge Posts" really does does not detract from the fact that it is not an accurate label for the action. With that, my preferred solution would be to rename "Merge Posts" to "Move Posts" in quickmod tools and mcp (and anywhere else that action is referenced). This includes the "Merge topic"/"Merge posts" tab label changed by rxu's patch. If such a rename is not feasible for 3.0 I still suggest doing it for 3.1. I strongly prefer renaming the label to "Move Posts" but even only considering rxu's patch I think it is still an improvement over the current UI: "Merge topic" is an entirely different action from "Merge posts", as pointed out by the ticket's reporter. FWIW I agree with the reporter's original report also.
          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          No pull request - changing to unreviewed patch.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited No pull request - changing to unreviewed patch.
          Hide
          rxu Ruslan Uzdenov added a comment -

          The pull request is open.

          Show
          rxu Ruslan Uzdenov added a comment - The pull request is open.
          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          While I was looking at the UI and testing this I noticed an inconsistency in "copy topic" item - the language constant for that reads FORK_TOPIC.

          If we are going to leave that as is it does not seem to make much sense to rename language constant for moving posts in 3.0.

          Therefore I propose to only edit the language in 3.0, and in 3.1 rename both constants to match current language.

          To that end here is an alternate pull request:

          https://github.com/phpbb/phpbb3/pull/181

          You will note that it has one change in template in each of the styles. This is because the code actually confused "merge topic" and "merge posts" and used the wrong constant. This lends credence to the original report and to the idea of renaming "merge posts" to "move posts" in my opinion.

          The quick mod tools UI can be further improved by specifying which topic is merged into which topic when "merge topic" is selected (currently I believe the topic you are in is merged into the topic selected later) and for those who do not understand what "move posts" means, that can be expanded to "split posts from this topic and merge them to another topic". The way to do this is to put the description/explanation text into tooltips that appear when user hovers over the respective option in the list.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited While I was looking at the UI and testing this I noticed an inconsistency in "copy topic" item - the language constant for that reads FORK_TOPIC. If we are going to leave that as is it does not seem to make much sense to rename language constant for moving posts in 3.0. Therefore I propose to only edit the language in 3.0, and in 3.1 rename both constants to match current language. To that end here is an alternate pull request: https://github.com/phpbb/phpbb3/pull/181 You will note that it has one change in template in each of the styles. This is because the code actually confused "merge topic" and "merge posts" and used the wrong constant. This lends credence to the original report and to the idea of renaming "merge posts" to "move posts" in my opinion. The quick mod tools UI can be further improved by specifying which topic is merged into which topic when "merge topic" is selected (currently I believe the topic you are in is merged into the topic selected later) and for those who do not understand what "move posts" means, that can be expanded to "split posts from this topic and merge them to another topic". The way to do this is to put the description/explanation text into tooltips that appear when user hovers over the respective option in the list.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          I created PHPBB3-10179 to fix language constant names in 3.1.

          The fix for 3.0 does not edit any constant names, only changes text. This should make things easier on translators.

          Show
          Oleg Oleg [X] (Inactive) added a comment - I created PHPBB3-10179 to fix language constant names in 3.1. The fix for 3.0 does not edit any constant names, only changes text. This should make things easier on translators.

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              PhilippK PhilippK
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development