Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9558

Use PHP timezone handling abilities

    Details

    • Type: New Feature
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Sessions
    • Labels:
      None

      Description

      Implement the RFC Switch to PHP timezone handling.

        Issue Links

          Activity

          Hide
          ToonArmy Chris Smith added a comment -

          chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">timezone" .
          ./phpBB/memberlist.php:			$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/index.php:	$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/feed.php:		$zone_offset = (int) $user->timezone + (int) $user->dst;
          ./phpBB/includes/functions_profile_fields.php:					return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true);
          ./phpBB/includes/acp/acp_board.php:		$old_tz = $user->timezone;
          ./phpBB/includes/acp/acp_board.php:		$user->timezone = $config['board_timezone'];
          ./phpBB/includes/acp/acp_board.php:		$user->timezone = $old_tz;
          

          chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">dst" .
          ./phpBB/memberlist.php:			$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/index.php:	$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
          ./phpBB/language/en/common.php:		'dst'	=> '[ <abbr title="Daylight Saving Time">DST</abbr> ]',
          ./phpBB/language/en/ucp.php:	'BOARD_DST'					=> 'Summer Time/<abbr title="Daylight Saving Time">DST</abbr> is in effect',
          ./phpBB/language/en/acp/board.php:	'SYSTEM_DST'					=> 'Enable Summer Time/<abbr title="Daylight Saving Time">DST</abbr>',
          ./phpBB/feed.php:		$zone_offset = (int) $user->timezone + (int) $user->dst;
          ./phpBB/includes/functions_profile_fields.php:					return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true);
          ./phpBB/includes/acp/acp_board.php:		$old_dst = $user->dst;
          ./phpBB/includes/acp/acp_board.php:		$user->dst = $config['board_dst'];
          ./phpBB/includes/acp/acp_board.php:		$user->dst = $old_dst;
          

          Show
          ToonArmy Chris Smith added a comment - chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">timezone" . ./phpBB/memberlist.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/index.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/feed.php: $zone_offset = (int) $user->timezone + (int) $user->dst; ./phpBB/includes/functions_profile_fields.php: return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true); ./phpBB/includes/acp/acp_board.php: $old_tz = $user->timezone; ./phpBB/includes/acp/acp_board.php: $user->timezone = $config['board_timezone']; ./phpBB/includes/acp/acp_board.php: $user->timezone = $old_tz; chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">dst" . ./phpBB/memberlist.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/index.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/language/en/common.php: 'dst' => '[ <abbr title="Daylight Saving Time">DST</abbr> ]', ./phpBB/language/en/ucp.php: 'BOARD_DST' => 'Summer Time/<abbr title="Daylight Saving Time">DST</abbr> is in effect', ./phpBB/language/en/acp/board.php: 'SYSTEM_DST' => 'Enable Summer Time/<abbr title="Daylight Saving Time">DST</abbr>', ./phpBB/feed.php: $zone_offset = (int) $user->timezone + (int) $user->dst; ./phpBB/includes/functions_profile_fields.php: return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true); ./phpBB/includes/acp/acp_board.php: $old_dst = $user->dst; ./phpBB/includes/acp/acp_board.php: $user->dst = $config['board_dst']; ./phpBB/includes/acp/acp_board.php: $user->dst = $old_dst;
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          When this is done, http://tracker.phpbb.com/browse/PHPBB3-10116 should be tested against the new code.

          Show
          Oleg Oleg [X] (Inactive) added a comment - When this is done, http://tracker.phpbb.com/browse/PHPBB3-10116 should be tested against the new code.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              ToonArmy Chris Smith
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development