Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9451

Unnecessary overhead in avatar_process_user function

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 3.0.x, 3.0.7-PL1
    • 3.0.8-RC1
    • Other
    • None
    • PHP Environment:
      Database:

    Description

      I noticed that the function avatar_process_user in includes/function_user.php checks whether we can upload, however in both instances of the function being used, this check has already been carried out. I have attached a patch which allows optional passing of the $can_upload value to the function to avoid the redundancy.

      Attachments

        Activity

          People

            bantu Andreas Fischer
            Thatbitextra Thatbitextra [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: