Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-9451

Unnecessary overhead in avatar_process_user function

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.0.8-RC1
    • 3.0.x, 3.0.7-PL1
    • Other
    • None
    • PHP Environment:
      Database:

      I noticed that the function avatar_process_user in includes/function_user.php checks whether we can upload, however in both instances of the function being used, this check has already been carried out. I have attached a patch which allows optional passing of the $can_upload value to the function to avoid the redundancy.

        1. avatar_process_user.patch
          2 kB

            bantu Andreas Fischer [X] (Inactive)
            Thatbitextra Thatbitextra [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: