Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9451

Unnecessary overhead in avatar_process_user function

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.x, 3.0.7-PL1
    • Fix Version/s: 3.0.8-RC1
    • Component/s: Other
    • Labels:
      None
    • Environment:
      PHP Environment:
      Database:

      Description

      I noticed that the function avatar_process_user in includes/function_user.php checks whether we can upload, however in both instances of the function being used, this check has already been carried out. I have attached a patch which allows optional passing of the $can_upload value to the function to avoid the redundancy.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Thanks for turning this into a git patch, nn-.

        I changed the author to Thatbitextra and adjusted the commit message to follow http://wiki.phpbb.com/display/DEV/Git.

        Show
        bantu Andreas Fischer added a comment - Thanks for turning this into a git patch, nn-. I changed the author to Thatbitextra and adjusted the commit message to follow http://wiki.phpbb.com/display/DEV/Git .

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            Thatbitextra Thatbitextra [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development