Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-8796

Mark forum(s) read (or mark topics read) marks some topics you haven't read

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.5
    • Fix Version/s: 3.1.0-a1
    • Component/s: Other
    • Labels:
      None

      Description

      I'm not sure if this goes under the category of a bug or a feature that could be improved, but the post review warning issue I raised in another bug report ( http://www.phpbb.com/bugs/phpbb3/52835 ) got me to thinking about a similar timing issue in connection with the way phpbb3 marks forums and topics read.

      Imagine a user who looks at the list of topics on viewforum, isn't interested in any of the unread ones and therefore clicks to mark the forum read. But between the time the user opened up the viewforum page and the time he clicks to mark the forum read, another user has posted a new topic or reply in the forum that the first user would have been interested in. In that case, the first user may never see that new topic or reply because he has inadvertently marked it read.

      It would be easy to solve this problem in a way analogous to the solution I suggested for the post review warning ( http://www.phpbb.com/bugs/phpbb3/52835 ): we could change each mark forum(s) unread or mark topics unread link that appears anywhere on the site (e.g. on index and viewforum) to pass the current time (as in effect when the user opened the page where the link appears) by adding '&time=xyz' and then we would have the function markread() (that appears in includes/functions.php) use that time (rather than time()) to determine what mark_time to use. (As in the post review warning solution, the solution comes at a cost of making the url the user sees a bit uglier.)

      This may seem like it is fixing a problem that isn't likely to occur very open, but on boards where it is really important to be aware of every new post or reply I think it would be worth fixing. I have a board where I really need to be aware of all posts and replies, and as a result I never use the mark read feature even if I can tell by the topic titles that I can skip a bunch of posts, so I know this change would improve usability for me.

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          I though about that aswell, and I'd like the idea to only mark the posts/topics read before the last view of viewforum.php

          Show
          nickvergessen Joas Schilling added a comment - I though about that aswell, and I'd like the idea to only mark the posts/topics read before the last view of viewforum.php
          Hide
          rxu Ruslan Uzdenov added a comment -

          There's a thought: we could pass max forum_last_post_time from the current page as a mark_time (alike viewtopic does).

          Show
          rxu Ruslan Uzdenov added a comment - There's a thought: we could pass max forum_last_post_time from the current page as a mark_time (alike viewtopic does).
          Hide
          asinshesq asinshesq added a comment -

          That would work. What I had in mind was a bit different: that we would set $current_time equal to time() early on in viewforum.php and in index.php (before those pages run their queries to fetch forum or topic info). We would then add that time to the url for the mark forums read or mark topics read link, and markread() would use that time to do its work.

          Show
          asinshesq asinshesq added a comment - That would work. What I had in mind was a bit different: that we would set $current_time equal to time() early on in viewforum.php and in index.php (before those pages run their queries to fetch forum or topic info). We would then add that time to the url for the mark forums read or mark topics read link, and markread() would use that time to do its work.
          Hide
          asinshesq asinshesq added a comment -

          This report was never resolved and it remains relevant to phpbb 3.0.8. I would have thought this one would be worth fixing.

          Show
          asinshesq asinshesq added a comment - This report was never resolved and it remains relevant to phpbb 3.0.8. I would have thought this one would be worth fixing.

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              asinshesq asinshesq
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development