Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7684

Empty if ($row['module_reqs'] != '') { }

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • 3.0.2
    • 3.0.3
    • Installation system
    • None
    • PHP Environment:
      Database:

    Description

      Found some useless-code in install/index.php

      			// Check any module pre-reqs
      			if ($row['module_reqs'] != '')
      			{
      			}

      next part is

      			// Module order not specified or module already assigned at this position?
      			if (!isset($row['module_order']) || isset($this->module_ary[$row['module_order']]))
      			{
      				$row['module_order'] = $max_module_order;
      				$max_module_order++;
      			}

      so it's not made to use else or else if.

      Attachments

        Activity

          People

            Acyd Burn Meik Sievertsen [X] (Inactive)
            nickvergessen Joas Schilling
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: