Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7129

E_STRICT errors in style.php when recompiling style components

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • 3.0.0
    • 3.0.1
    • Styles
    • None
    • PHP Environment: 5.2.1
      Database:

    Description

      How to reproduce:
      [list: 12dlvq4f]* In your php.ini, set error_reporting to E_ALL | E_STRICT

      • Install clean phpBB 3.0.0
      • Enable "recompile stale style components" in the acp
      • save or touch any of the .css files in styles/prosilver/theme
      • open your forum in the browser -> you get a page without css
      • If you directly open style.php?sid=xxxx&id=1&lang=en in your browser, you see the reason:

        Strict Standards: Non-static method acp_styles::db_theme_data() should not be called statically in path\to\phpBB3\style.php on line 181
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Strict Standards: Non-static method acp_styles::load_css_file() should not be called statically in path\to\phpBB3\includes\acp\acp_styles.php on line 2397
        Warning: Cannot modify header information - headers already sent by (output started at path\to\phpBB3\style.php:181) in path\to\phpBB3\style.php on line 200
        Warning: Cannot modify header information - headers already sent by (output started at path\to\phpBB3\style.php:181) in path\to\phpBB3\style.php on line 207

      In common.php there is a call to error_reporting() that is supposed to suppress E_STRICT errors but since style.php does not include common.php, the value from php.ini is used instead

      Attachments

        Activity

          People

            naderman Nils Adermann
            Pyramide Pyramide [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: