On imagesets and languages.

Almost all of the styles come with english as their only imageset language.

Almost none of the imagesets get translated to the other languages. (Actually, only the default). But if someone creates a new style, he includes an imageset for his language and for english language, so more people can use it.

So, to install the style, one needs to copy the imageset/en to the imageset/lang for each installed language for the style to work. That is not quite logical, because the imageset/lang will hold the english imageset, not the imageset for lang. And that is just some (actually, the same as number of installed languages - 1) extra steps needed to install a style, instead of just simple download, upload, and enable.

So, instead of imageset/lang, images should be loaded from imageset/en, if imageset/lang does not exist, because loading them from imageset/lang makes the board unusable.

To blindly load default_lang does not help, because it also does not exist in most cases.

Suggested patch (to phpBB 3.0.0):
in file includes/session.php
find:

$this->img_lang = (file_exists($phpbb_root_path . 'styles/' . $this->theme['imageset_path'] . '/imageset/' . $this->lang_name)) ? $this->lang_name : $config['default_lang'];

replace with:

$this->img_lang = (file_exists($phpbb_root_path . 'styles/' . $this->theme['imageset_path'] . '/imageset/' . $this->lang_name)) ? $this->lang_name : (file_exists($phpbb_root_path . 'styles/' . $this->theme['imageset_path'] . '/imageset/' . $config['default_lang'])) ? $config['default_lang'] : 'en';

/ChALkeR

P.S. Thank you for all your work , and sorry for my bad english.