Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7074

Wrong code layout in adm/index.php

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • 3.0.x
    • 3.0.1
    • ACP
    • None
    • PHP Environment:
      Database:

    Description

      A minor violation of the coding guidelines I came across while reading the commit mails , in adm/index.php:

                             case 'string' :                               $max = (isset($column[1])) ? min($column[1],$type['max']) : $type['max'];                               if (strlen($value['value']) > $max)                               {                                       $error[] = sprintf($user->lang['SETTING_TOO_LONG'], $user->lang[$value['lang']], $max);                               }                                                              break;                                              case 'int':                                $min = (isset($column[1])) ? max($column[1],$type['min']) : $type['min'];                               $max = (isset($column[2])) ? min($column[2],$type['max']) : $type['max'];                               if ($value['value'] < $min)                               {                                       $error[] = sprintf($user->lang['SETTING_TOO_LOW'], $user->lang[$value['lang']], $min);                               }                               else if ($value['value'] > $max)                               {                                       $error[] = sprintf($user->lang['SETTING_TOO_BIG'], $user->lang[$value['lang']], $max);                               }                               break; 

      The two break statements are indented incorrectly .

      Attachments

        Activity

          People

            Acyd Burn Meik Sievertsen [X] (Inactive)
            Schumi Schumi
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: