Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-7057

Quicksearch uses POST, thus the page expires!

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Search
    • Labels:
      None

      Description

      Quicksearch uses postdata, rather than getdata, so Results page expires and cannot be back-navigated into while viewing individual result pages.

      Is there an easy fix for this? Can we expect a fix for this?

      Thanxs

      Dennis

        Issue Links

          Activity

          Hide
          naderman Nils Adermann added a comment -

          It seems to me like it was entirely random that this was ever implemented at POST and that there is no good reason for that. Using POST is causing problems for users. I'll remove the cache changes from the pull request because they appear to be unecessary.

          Show
          naderman Nils Adermann added a comment - It seems to me like it was entirely random that this was ever implemented at POST and that there is no good reason for that. Using POST is causing problems for users. I'll remove the cache changes from the pull request because they appear to be unecessary.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          You should test that opera does the right thing when navigating search results when new posts are posted, especially if you remove header additions.

          Show
          Oleg Oleg [X] (Inactive) added a comment - You should test that opera does the right thing when navigating search results when new posts are posted, especially if you remove header additions.
          Hide
          naderman Nils Adermann added a comment -

          Works fine on Opera too. There's really no reason why this would be an issue with a GET form since it's just going from one URL to another. Only situation where you can possibly end up with caching weirdness in browsers is with a POST form because POST can change state on the server so resending it when going back isn't necessarily the right behaviour. So tested on firefox, opera, chrome and IE. I think it can be merged.

          Show
          naderman Nils Adermann added a comment - Works fine on Opera too. There's really no reason why this would be an issue with a GET form since it's just going from one URL to another. Only situation where you can possibly end up with caching weirdness in browsers is with a POST form because POST can change state on the server so resending it when going back isn't necessarily the right behaviour. So tested on firefox, opera, chrome and IE. I think it can be merged.
          Hide
          artiprinted artiprinted [X] (Inactive) added a comment -

          Thank you so very much for looking into this. I cannot wait till it is released and I can install on my board.

          Show
          artiprinted artiprinted [X] (Inactive) added a comment - Thank you so very much for looking into this. I cannot wait till it is released and I can install on my board.
          Hide
          artiprinted artiprinted [X] (Inactive) added a comment -

          Just loaded .9 and It Works!!! Thanks!!!!

          Show
          artiprinted artiprinted [X] (Inactive) added a comment - Just loaded .9 and It Works!!! Thanks!!!!

            People

            • Assignee:
              naderman Nils Adermann
              Reporter:
              webants webants [X] (Inactive)
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development