Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13815

Event parameters in posting do not affect behavior as expected

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.3
    • Fix Version/s: 3.1.6-RC1
    • Component/s: Events
    • Labels:
      None

      Description

      In the events core.posting_modify_submit_post_before and core.posting_modify_submit_post_after, the parameter 'error' does not have any impact in further execution, and particularly it does not achieve what is specified in the docblock: "Any error strings; a non-empty array aborts form submission". Similarly, the parameter 'submit' is useless here as well, as both events are within an "if $submit", therefore this parameter will always be true, and changing it will not have further impact.
      Please, remove both parameters from these events.

        Attachments

          Activity

            People

            • Assignee:
              Marc Marc
              Reporter:
              javiexin javiexin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: