Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13316

reCAPTCHA does not work on secured connection

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.2-RC1
    • Component/s: None
    • Labels:
      None
    • Environment:
      any

      Description

      In file phpbb/captcha/plugins/recaptcha.php is a line with:
      function phpbb_recaptcha()
      which should, presumably, be a constructor - it (if accessed by secure connection) only sets URL to https instead of http.
      But the constructor is not called because of wrong method name.

      Fix: rename method to __construct()

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Code Sniffer is supposed to catch these in general via

         <!-- Constructors MUST be called __construct() instead of after the class. -->
         <rule ref="Generic.NamingConventions.ConstructorName" />
        

        Unfortunately this does not work in this case, due to prefix to namespace transformation. The class name no longer is phpbb_recaptcha, so this method is not detected as a constructor.

        Show
        bantu Andreas Fischer added a comment - Code Sniffer is supposed to catch these in general via <!-- Constructors MUST be called __construct() instead of after the class. --> <rule ref="Generic.NamingConventions.ConstructorName" /> Unfortunately this does not work in this case, due to prefix to namespace transformation. The class name no longer is phpbb_recaptcha, so this method is not detected as a constructor.

          People

          • Assignee:
            prototech prototech
            Reporter:
            OndraSter OndraSter
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development