Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13026

Add template vars array to core.viewonline_overwrite_location to allow modifying/adding template vars

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0-RC4
    • Component/s: Events
    • Labels:
      None

      Description

      Currently user row template variables are being assigned after core.viewonline_overwrite_location is trigerred in viewonline.php so it can't be handled by event.
      Suggestion is to create an array of template vars and pass it to event to allow modifying/adding template vars for every user row.

        Issue Links

          Activity

          Hide
          VSE Matt Friedman added a comment - - edited

          This Patch breaks the viewonline core event!

          The whole point of the event is to manipulate variables before they get inserted into the template var array... This patch moves the template var array before the event, so all the available variables we have to manipulate are useless, and none of them are used again after the core event.

          This needs to be reverted! It breaks BC and needs to be re-thought in a way that does not break BC, ie: create a separate new event for access to template array.

          Show
          VSE Matt Friedman added a comment - - edited This Patch breaks the viewonline core event! The whole point of the event is to manipulate variables before they get inserted into the template var array... This patch moves the template var array before the event, so all the available variables we have to manipulate are useless, and none of them are used again after the core event. This needs to be reverted! It breaks BC and needs to be re-thought in a way that does not break BC, ie: create a separate new event for access to template array.
          Hide
          VSE Matt Friedman added a comment -
          Show
          VSE Matt Friedman added a comment - Reverted https://github.com/phpbb/phpbb/pull/2934

            People

            • Assignee:
              Marc Marc
              Reporter:
              rxu Ruslan Uzdenov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development