Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-12968

Move away from getimagesize

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Duplicate
    • 3.0.12, 3.1.0-RC3
    • 3.2.0-a1
    • None
    • None

    Description

      getimagesize() can be very costly when someone posts a multi-megabyte image and the board has image size restrictions in place. It will download the entire image and then process it. We can significantly improve the speed if we roll our own dimension checking routine. We really only need to download the first few bytes of the image to determine its type and dimensions.

      Attachments

        Issue Links

          Activity

            People

              nickvergessen Joas Schilling [X] (Inactive)
              Noxwizard Noxwizard
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: