Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-12968

Move away from getimagesize

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Minor Minor
    • 3.2.0-a1
    • 3.0.12, 3.1.0-RC3
    • None
    • None

      getimagesize() can be very costly when someone posts a multi-megabyte image and the board has image size restrictions in place. It will download the entire image and then process it. We can significantly improve the speed if we roll our own dimension checking routine. We really only need to download the first few bytes of the image to determine its type and dimensions.

            nickvergessen Joas Schilling
            Noxwizard Patrick Webster
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: