Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11574

Unable to "auto update" from 3.0 to 3.1

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Update system
    • Labels:
      None

      Description

      There are several problems in install_update.php and index.php which make it unable to update.

      1. Dependencies are missing (maybe they should be included in the update packages)
      2. We need a class loader for files in install/update/new/
      3. We need to phpbb_require_updated some files which are new in 3.1

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          To test/reproduce:

          1. Install 3.0.11
          2. Download 3.0.11 to 3.1-dev Update from nightly: https://bamboo.phpbb.com/browse/PHPBB3-DEVELOP/latestSuccessful/artifact/JOBPACKAGE/Release-Files
          3. Go to install/

          Show
          nickvergessen Joas Schilling added a comment - To test/reproduce: 1. Install 3.0.11 2. Download 3.0.11 to 3.1-dev Update from nightly: https://bamboo.phpbb.com/browse/PHPBB3-DEVELOP/latestSuccessful/artifact/JOBPACKAGE/Release-Files 3. Go to install/
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Do we even want to try to support this for 3.0 to 3.1? With all the changes in the update, this seems like it could become quite troublesome.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Do we even want to try to support this for 3.0 to 3.1? With all the changes in the update, this seems like it could become quite troublesome.
          Hide
          nickvergessen Joas Schilling added a comment -

          These are mostly general problems
          They all can happen in some 3.1.x to 3.1.y aswell

          For 1. We add a new dependency which is used in the updater/installer
          For 2. We add a new class/new method on a class which is used in the updater/isntaller
          For 3. Obvious

          Show
          nickvergessen Joas Schilling added a comment - These are mostly general problems They all can happen in some 3.1.x to 3.1.y aswell For 1. We add a new dependency which is used in the updater/installer For 2. We add a new class/new method on a class which is used in the updater/isntaller For 3. Obvious
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          If we do not need to worry about updates from 3.0, this should block the second release in the 3.1 branch, not the first alpha.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - If we do not need to worry about updates from 3.0, this should block the second release in the 3.1 branch, not the first alpha.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          Since there was no response to my comment, I'm assuming that means agreement, and have marked this as a blocker for a2 since it is not required until (at least) then.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - Since there was no response to my comment, I'm assuming that means agreement, and have marked this as a blocker for a2 since it is not required until (at least) then.
          Hide
          nickvergessen Joas Schilling added a comment -

          No I do not agree.

          Show
          nickvergessen Joas Schilling added a comment - No I do not agree.
          Hide
          naderman Nils Adermann added a comment -

          Generally we should reduce the amount of code in the install directory which gets deleted and is not further available to the absolute minimum. Ideally at some point the installer will merely be a front controller with all code defined elsewhere.

          Also testing 3.1 with any meaningful data is hardly possible without upgrading 3.0 boards, so this should remain an A-1 blocker.

          Show
          naderman Nils Adermann added a comment - Generally we should reduce the amount of code in the install directory which gets deleted and is not further available to the absolute minimum. Ideally at some point the installer will merely be a front controller with all code defined elsewhere. Also testing 3.1 with any meaningful data is hardly possible without upgrading 3.0 boards, so this should remain an A-1 blocker.
          Hide
          EXreaction EXreaction [X] (Inactive) added a comment -

          You do not need to run the auto-updater to update from 3.0 to 3.1, in fact I'm pretty sure that for most people with any mods installed it's going to be next to impossible to do because of all the changes. Running database_update.php works perfectly fine to go from 3.0 to 3.1, it just requires a fresh set of files.

          Show
          EXreaction EXreaction [X] (Inactive) added a comment - You do not need to run the auto-updater to update from 3.0 to 3.1, in fact I'm pretty sure that for most people with any mods installed it's going to be next to impossible to do because of all the changes. Running database_update.php works perfectly fine to go from 3.0 to 3.1, it just requires a fresh set of files.
          Hide
          nickvergessen Joas Schilling added a comment -

          I'm working on a patch right now, but we run into some limitations, which require some things:

          E.g.: If we include the service.yml we need to include all .yml files into the update package, otherwise it wont find the files.

          Show
          nickvergessen Joas Schilling added a comment - I'm working on a patch right now, but we run into some limitations, which require some things: E.g.: If we include the service.yml we need to include all .yml files into the update package, otherwise it wont find the files.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nickvergessen Joas Schilling
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development