Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11292

Newlines removed in display of PM reports, no clickable links in PM reports

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.11
    • Fix Version/s: 3.0.12-RC1
    • Labels:
      None
    • Environment:
      Any, tested with Apache/2.2.21 (Win32) mod_ssl/2.2.21 OpenSSL/1.0.0e PHP/5.3.8 mod_perl/2.0.4 Perl/v5.10.1 and Firefox 17.0.1.

      Description

      When using newlines in report descriptions for PMs, the newlines are not displayed in the report that is displayed to the moderator. For example

      This is the first line of text.
      This is the second line of text.

      will be displayed as

      This is the firstline of text. This is the second line of text.

      When posts are reported, this will instead appear as expected.

      In addition, when including links within the report text, these are not automatically made clickable for the moderator when a PM is reported, but they are made clickable when a post is reported.

      The fix to both of these consists of merely one additional line of code in includes/mcp/mcp_pm_reports.php:

      $report['report_text'] = make_clickable(bbcode_nl2br($report['report_text']));

      after

      $message = bbcode_nl2br($message);
      $message = smiley_text($message);

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Feel free to send a pull request on github. See e.g. https://wiki.phpbb.com/Git#Branch_Names

        Show
        bantu Andreas Fischer added a comment - Feel free to send a pull request on github. See e.g. https://wiki.phpbb.com/Git#Branch_Names
        Hide
        gn#36 gn#36 added a comment -

        The described patch as a pull request.

        Show
        gn#36 gn#36 added a comment - The described patch as a pull request.

          People

          • Assignee:
            bantu Andreas Fischer
            Reporter:
            gn#36 gn#36
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development