Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11162

Get rid of $db->sql_return_on_error(true) trickery when splitting/merging topics

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.11
    • Fix Version/s: 3.0.12-RC1
    • Component/s: None
    • Labels:
      None

      Description

      Background: https://github.com/phpbb/phpbb3/pull/988

      Instead of potentially doing the update that may fail, add conditions to only update rows that can be updated. The subsequent delete will take care of any left over rows.

      My expectation is that the current code does not update any rows if any of them fail on postgres and updates all rows other than failing ones on mysql.

      3.0 and 3.1 will need separate patches because of https://github.com/phpbb/phpbb3/pull/988.

        Attachments

          Activity

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: