Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10453

PM viewmessage page is misplacing the online icon

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.6, 3.0.7, 3.0.8, 3.0.9
    • Fix Version/s: 3.0.11-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      As per the Issue title, the pm screen is misplacing the online icon, see print screens
      I have a patch ready, it would be nice to introduce this on phpBB.

      It use less HTML/CSS code then the old one, and it looks nicer when you view a pm (if i must say it by my self )

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        I like the approach, but I dont like the position absolute ( https://github.com/phpbb/phpbb3/pull/461/files#L4R353 ) as I don't know what happens with a enormous long translation of the button text here.
        I'd just keep it in a separate line, like it is now.

        Show
        nickvergessen Joas Schilling added a comment - I like the approach, but I dont like the position absolute ( https://github.com/phpbb/phpbb3/pull/461/files#L4R353 ) as I don't know what happens with a enormous long translation of the button text here. I'd just keep it in a separate line, like it is now.
        Hide
        Raimon Raimon Meuldijk added a comment -

        Joas Schilling; I would not recommend as design wise to place it below, it makes the box bigger (in height), the best way is just to place it near the buttons so you keep the same height of the panel. I made some changes to it so the text move along with it when the buttons are larger.

        Show
        Raimon Raimon Meuldijk added a comment - Joas Schilling; I would not recommend as design wise to place it below, it makes the box bigger (in height), the best way is just to place it near the buttons so you keep the same height of the panel. I made some changes to it so the text move along with it when the buttons are larger.
        Hide
        Arty Vjacheslav Trushkin added a comment -

        Spacing issues

        Show
        Arty Vjacheslav Trushkin added a comment - Spacing issues

          People

          • Assignee:
            Arty Vjacheslav Trushkin
            Reporter:
            Raimon Raimon Meuldijk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development