Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10186

UCP signature panel displays when not authed for signatures

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Labels:
      None

      Description

      The signature panel displays even when a user does not have the auths to create/edit their signature.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          In light of https://github.com/phpbb/phpbb3/pull/712 and http://tracker.phpbb.com/browse/PHPBB3-10664 I believe the fix here was incorrect.

          The modules table entry for signature module has no acl requirement. Whereas the requirement should be u_sig. Instead of performing the check manually in the code as had been done in the merged patch, the modules table entry should be altered to include correct acl requirement.

          Signature reference was actually in the topic here: https://www.phpbb.com/community/viewtopic.php?p=13114326&sid=a28f64d7f083d70bbcebc112d17e21ac#p13114326

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited In light of https://github.com/phpbb/phpbb3/pull/712 and http://tracker.phpbb.com/browse/PHPBB3-10664 I believe the fix here was incorrect. The modules table entry for signature module has no acl requirement. Whereas the requirement should be u_sig. Instead of performing the check manually in the code as had been done in the merged patch, the modules table entry should be altered to include correct acl requirement. Signature reference was actually in the topic here: https://www.phpbb.com/community/viewtopic.php?p=13114326&sid=a28f64d7f083d70bbcebc112d17e21ac#p13114326

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              RMcGirr83 Rich McGirr
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development