Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-8836

Minor cosmetic issue - hyphen vs. dash

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • 3.0.7
    • 3.0.x
    • Other
    • None
    • PHP Environment:
      Database:

      This is a minor cosmetic issue, certainly not a show-stopper.

      It occurred to me while looking at the new 3.0.6 feeds, that the statistics line would look better using the more typographically correct em dash (— / '—' / "\xE2\x80\x94"), rather than hyphen/minus ('-' / "\x2D"), since we're using UTF-8.

      Here's what we have in 3.0.6-RC4:
      Statistics: Posted by Murph - Sat, 31 Oct 2009 01:12:48 GMT - Replies 0 - Views 8

      Here's what I'm suggesting:
      Statistics: Posted by Murph — Sat, 31 Oct 2009 01:12:48 GMT — Replies 0 — Views 8

      There are 4 cases of this in feed.php, in adjust_item, at the end of each class, similar to:

      $item_row['statistics'] = $user->lang['POSTED'] . ' ' . $user->lang['POST_BY_AUTHOR'] . ' ' . $user_link . ' - ' . $user->format_date($time). ' - ' . $user->lang['REPLIES'] . ' ' . $row['topic_replies'] . ' - ' . $user->lang['VIEWS'] . ' ' . $row['topic_views'];

      There are also a few places elsewhere which could similarly be changed to the UTF-8 dash.

      In memberlist.php:

      'VISITED'               => (empty($last_visit)) ? ' — ' : $user->format_date($last_visit),

      In viewforum.php:

      page_header($user->lang['VIEW_FORUM'] . ' — ' . $forum_data['forum_name'], true, $forum_id);

      In viewtopic.php:

      page_header($user->lang['VIEW_TOPIC'] . ' — ' . $topic_data['topic_title'], true, $forum_id);

      In styles/prosilver/template/forumlist_body.html:

      <!-- IF S_ENABLE_FEEDS and forumrow.S_FEED_ENABLED --><!-- <a class="feed-icon-forum" title="{L_FEED} - {forumrow.FORUM_NAME}" href="{U_FEED}?f={forumrow.FORUM_ID}"><img src="{T_THEME_PATH}/images/feed.gif" alt="{L_FEED} - {forumrow.FORUM_NAME}" /></a> --><!-- ENDIF -->

      In styles/prosilver/template/overall_header.html, titles in 6 link lines:

      <link rel="alternate" type="application/atom+xml" title="{L_FEED} - {SITENAME}" href="{U_FEED}" />

      There's almost certainly a few other cases lurking around, but I think that's the most obvious ones on the main board pages.

            bantu Andreas Fischer [X] (Inactive)
            paul.j.murphy paul.j.murphy
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: