Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-6084

incomplete prosilver IE rtl fix

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • 3.0.0
    • 3.0.x
    • Styles
    • None
    • PHP Environment:
      Database:

      this problem was dealt with several times, and eventually solved by acydburn. unfortunately the solution was incomplete. fortunately, the fix is easy.

      SUMMARY:
      in IE only, with RTL languages, in the bottom navbar, text and icons overlap.

      DISCUSSION:
      the problem was solved some time ago for the top navbar by acydburn by moving the class="icon-xxx" from the <a> tag to the <li> tag.
      later, acyd made the same change to the bottom (page_footer) navbar. (see http://phpbb.cvs.sourceforge.net/phpbb/phpBB2/styles/prosilver/template/overall_footer.html?r1=1.8&r2=1.9&diff_format=l )

      unfortunately, the last change was not complete: it was done for the U_INDEX link only. in order for the rest of the links to appear properly in IE with RTL languages, the same modification should be done for S_WATCH_FORUM_LINK, U_WATCH_TOPIC, U_BOOKMARK_TOPIC, U_BUMP_TOPIC.

      in other words, in overall_footer.php, change:

                          <!-- IF S_WATCH_FORUM_LINK --><li><a href="{S_WATCH_FORUM_LINK}" <!-- IF S_WATCHING_FORUM -->class="icon-unsubscribe"<!-- ELSE -->class="icon-subscribe"<!-- ENDIF --> title="{S_WATCH_FORUM_TITLE}">{S_WATCH_FORUM_TITLE}</a></li><!-- ENDIF -->                    <!-- IF U_WATCH_TOPIC --><li><a href="{U_WATCH_TOPIC}" title="{L_WATCH_TOPIC}" <!-- IF S_WATCHING_TOPIC -->class="icon-unsubscribe"<!-- ELSE -->class="icon-subscribe"<!-- ENDIF -->>{L_WATCH_TOPIC}</a></li><!-- ENDIF -->                    <!-- IF U_BOOKMARK_TOPIC --><li><a href="{U_BOOKMARK_TOPIC}" title="{L_BOOKMARK_TOPIC}" class="icon-bookmark">{L_BOOKMARK_TOPIC}</a></li><!-- ENDIF -->                    <!-- IF U_BUMP_TOPIC --><li><a href="{U_BUMP_TOPIC}" title="{L_BUMP_TOPIC}" class="icon-bump">{L_BUMP_TOPIC}</a></li><!-- ENDIF -->     

      to

                          <!-- IF S_WATCH_FORUM_LINK --><li <!-- IF S_WATCHING_FORUM -->class="icon-unsubscribe"<!-- ELSE -->class="icon-subscribe"<!-- ENDIF -->><a href="{S_WATCH_FORUM_LINK}" title="{S_WATCH_FORUM_TITLE}">{S_WATCH_FORUM_TITLE}</a></li><!-- ENDIF -->                    <!-- IF U_WATCH_TOPIC --><li <!-- IF S_WATCHING_TOPIC -->class="icon-unsubscribe"<!-- ELSE -->class="icon-subscribe"<!-- ENDIF -->><a href="{U_WATCH_TOPIC}" title="{L_WATCH_TOPIC}">{L_WATCH_TOPIC}</a></li><!-- ENDIF -->                    <!-- IF U_BOOKMARK_TOPIC --><li class="icon-bookmark"><a href="{U_BOOKMARK_TOPIC}" title="{L_BOOKMARK_TOPIC}">{L_BOOKMARK_TOPIC}</a></li><!-- ENDIF -->                    <!-- IF U_BUMP_TOPIC --><li class="icon-bump"><a href="{U_BUMP_TOPIC}" title="{L_BUMP_TOPIC}" >{L_BUMP_TOPIC}</a></li><!-- ENDIF -->     

            Acyd Burn Meik Sievertsen [X] (Inactive)
            arod-1 arod-1 [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: