Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-4866

small but annoying javascript error

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • 3.0.1
    • 3.0.x
    • Styles
    • None
    • PHP Environment:
      Database:

      in subsilver, files overall_header.html and simple_header.html, the following javascript piece appear:

          window.onload = function()    {        for (i = 0; i <= onload_functions.length; i++)        {            eval(onload_functions[i]);        }    }    window.onunload = function()    {        for (i = 0; i <= onunload_functions.length; i++)        {            eval(onunload_functions[i]);        }    } 

      first and foremost, the loops should run to
      i < onunload_functions.length
      and not
      i <= onunload_functions.length
      in addition, it is polite, in javascript, to define variables, so it should be
      for (var i = 0; i < onunload_functions.length; i++)

            Kellanved Kellanved [X] (Inactive)
            arod-1 arod-1 [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: