Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-17563

CodeSniffer ruleset (PPSSE) not fully compatible with CS 4

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 3.3.15
    • None

      I'm currently updating phpBB Ext Check for CodeSniffer 4.0. Before 4.0, I was using CS 3.13.2. In addition to various necessary adjustments for CS 4, I also noticed a problem with PPSSE.

      At first, I suspected my specially constructed test ext, but then I tested one ext each from different developers, and the problem appeared with every ext. Suddenly, a file that hadn't been detected before is reported. However, the cause of the report isn't an error with the developer, but with PPSSE:

      Example for the About Us 2.1.4 ext:

      CS ruleset    : phpBB PHP Strict Standard Extensions
      Extensions    : php
      Files found   : 15
      Files affected: 1
       
      FILE: phpbb3-about-us-2.1.4\event\main_listener.php
      --------------------------------------------------------------------------------
      FOUND 4 ERRORS AFFECTING 4 LINES
      --------------------------------------------------------------------------------
        1 | ERROR | An error occurred during processing; checking has been aborted.
          |       | The error message was: Uninitialized string offset 0 in
          |       | \lib\phpbb\php-strict-standard-extensions_3\phpbb\Sniffs\Namespaces\UnusedUseSniff.php
          |       | on line 106
          |       | The error originated in the phpbb.Namespaces.UnusedUse sniff on
          |       | line 106.
       54 | ERROR | Either use statement or full name must be used.
       68 | ERROR | Either use statement or full name must be used.
       86 | ERROR | Either use statement or full name must be used.
      -------------------------------------------------------------------------------
      

      Tested with:

      phpBB Ext Check 1.10
      PHP 8.4.8 and 8.4.13
      CodeSniffer 4.0 (Release)
      PPSSE 2025.5.14 [7268859] 

      Matt, as additional information: I briefly downgraded CS from 4.0 to 3.13.4, which is two versions further than what I had before upgrading to 4.0. This made PPSSE work perfectly again. This means the problem must be directly related to CS 4.0.

       

      edit: Added the full EC report for the TFP extension for rxu. This is the sixth extension I've tested.

            Unassigned Unassigned
            LukeWCS LukeWCS
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: