Loading...

Type: Bug
Resolution: Unresolved
Priority: Major
Fix Version/s: None
Affects Version/s: 4.0.0-a2
Component/s: Notification System
Labels:
None

The webpush uses sql_in_set with an array of users that could be unexpectedly empty, particularly after removing banned users from the users to notify array in the notify_using_webpush() method.

Suggest early return if $notify_users is empty after doing the array_diff to it with $banned_users.

Report from the extension:

https://www.phpbb.com/customise/db/extension/webpushnotifications/support/topic/250144?p=893200#p893200

Error message from phpBB 4.0.0-a2

ErrorException:

User Error: SQL ERROR [ mysqli ]<br /><br /> [0]<br /><br />SQL<br /><br />No values specified for SQL IN comparison

  at /Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/db/driver/driver.php:1094

  at phpbb\db\driver\driver->sql_error('No values specified for SQL IN comparison')

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/db/driver/driver.php:629)

  at phpbb\db\driver\driver->sql_in_set('user_id', array(), false, false)

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/db/driver/factory.php:467)

  at phpbb\db\driver\factory->sql_in_set('user_id', array())

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/method/webpush.php:411)

  at phpbb\notification\method\webpush->get_user_subscription_map(array())

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/method/webpush.php:204)

  at phpbb\notification\method\webpush->notify_using_webpush()

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/method/webpush.php:168)

  at phpbb\notification\method\webpush->notify()

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/manager.php:434)

  at phpbb\notification\manager->add_notifications_for_users('notification.type.quote', array('topic_title' => 'Test', 'topic_first_post_id' => 5, 'topic_last_post_id' => 5, 'topic_time_limit' => 0, 'topic_attachment' => 0, 'post_id' => 6, 'topic_id' => 4, 'forum_id' => 2, 'icon_id' => 0, 'poster_id' => 2, 'enable_sig' => true, 'enable_bbcode' => true, 'enable_smilies' => true, 'enable_urls' => true, 'enable_indexing' => true, 'message_md5' => 'dc5276314695a6d8769d237fce7f35a7', 'post_checksum' => '0cbc6611f5540bd0809a388dc95a615b', 'post_edit_reason' => '', 'post_edit_user' => 0, 'forum_parents' => 'a:1:{i:1;a:2:{i:0;s:19:"Your first category";i:1;i:0;}}', 'forum_name' => 'Your first forum', 'notify' => false, 'notify_set' => 0, 'poster_ip' => '::1', 'post_edit_locked' => 0, 'bbcode_bitfield' => '', 'bbcode_uid' => 'nohh6g', 'message' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'attachment_data' => array(), 'filename_data' => array('filecomment' => ''), 'topic_status' => '0', 'topic_visibility' => '1', 'post_visibility' => '1', 'post_username' => 'admin', 'post_text' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'post_time' => 1739814866, 'post_subject' => 'Re: Test'), array(array('notification.method.board', 'notification.method.webpush')))

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/manager.php:321)

  at phpbb\notification\manager->add_notifications('notification.type.quote', array('topic_title' => 'Test', 'topic_first_post_id' => 5, 'topic_last_post_id' => 5, 'topic_time_limit' => 0, 'topic_attachment' => 0, 'post_id' => 6, 'topic_id' => 4, 'forum_id' => 2, 'icon_id' => 0, 'poster_id' => 2, 'enable_sig' => true, 'enable_bbcode' => true, 'enable_smilies' => true, 'enable_urls' => true, 'enable_indexing' => true, 'message_md5' => 'dc5276314695a6d8769d237fce7f35a7', 'post_checksum' => '0cbc6611f5540bd0809a388dc95a615b', 'post_edit_reason' => '', 'post_edit_user' => 0, 'forum_parents' => 'a:1:{i:1;a:2:{i:0;s:19:"Your first category";i:1;i:0;}}', 'forum_name' => 'Your first forum', 'notify' => false, 'notify_set' => 0, 'poster_ip' => '::1', 'post_edit_locked' => 0, 'bbcode_bitfield' => '', 'bbcode_uid' => 'nohh6g', 'message' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'attachment_data' => array(), 'filename_data' => array('filecomment' => ''), 'topic_status' => '0', 'topic_visibility' => '1', 'post_visibility' => '1', 'post_username' => 'admin', 'post_text' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'post_time' => 1739814866, 'post_subject' => 'Re: Test'), array('ignore_users' => array()))

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/phpbb/notification/manager.php:292)

  at phpbb\notification\manager->add_notifications(array('notification.type.mention', 'notification.type.quote', 'notification.type.bookmark', 'notification.type.post', 'notification.type.forum'), array('topic_title' => 'Test', 'topic_first_post_id' => 5, 'topic_last_post_id' => 5, 'topic_time_limit' => 0, 'topic_attachment' => 0, 'post_id' => 6, 'topic_id' => 4, 'forum_id' => 2, 'icon_id' => 0, 'poster_id' => 2, 'enable_sig' => true, 'enable_bbcode' => true, 'enable_smilies' => true, 'enable_urls' => true, 'enable_indexing' => true, 'message_md5' => 'dc5276314695a6d8769d237fce7f35a7', 'post_checksum' => '0cbc6611f5540bd0809a388dc95a615b', 'post_edit_reason' => '', 'post_edit_user' => 0, 'forum_parents' => 'a:1:{i:1;a:2:{i:0;s:19:"Your first category";i:1;i:0;}}', 'forum_name' => 'Your first forum', 'notify' => false, 'notify_set' => 0, 'poster_ip' => '::1', 'post_edit_locked' => 0, 'bbcode_bitfield' => '', 'bbcode_uid' => 'nohh6g', 'message' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'attachment_data' => array(), 'filename_data' => array('filecomment' => ''), 'topic_status' => '0', 'topic_visibility' => '1', 'post_visibility' => '1', 'post_username' => 'admin', 'post_text' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'post_time' => 1739814866, 'post_subject' => 'Re: Test'))

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/includes/functions_posting.php:2477)

  at submit_post('quote', 'Re: Test', 'admin', 0, array(), array('topic_title' => 'Test', 'topic_first_post_id' => 5, 'topic_last_post_id' => 5, 'topic_time_limit' => 0, 'topic_attachment' => 0, 'post_id' => 6, 'topic_id' => 4, 'forum_id' => 2, 'icon_id' => 0, 'poster_id' => 58, 'enable_sig' => true, 'enable_bbcode' => true, 'enable_smilies' => true, 'enable_urls' => true, 'enable_indexing' => true, 'message_md5' => 'dc5276314695a6d8769d237fce7f35a7', 'post_checksum' => '0cbc6611f5540bd0809a388dc95a615b', 'post_edit_reason' => '', 'post_edit_user' => 0, 'forum_parents' => 'a:1:{i:1;a:2:{i:0;s:19:"Your first category";i:1;i:0;}}', 'forum_name' => 'Your first forum', 'notify' => false, 'notify_set' => 0, 'poster_ip' => '::1', 'post_edit_locked' => 0, 'bbcode_bitfield' => '', 'bbcode_uid' => 'nohh6g', 'message' => '<r><QUOTE author="user1" post_id="5" time="1739814824" user_id="58"><s>[quote=user1 post_id=5 time=1739814824 user_id=58]</s>Test<e>[/quote]</e></QUOTE>We banned you</r>', 'attachment_data' => array(), 'filename_data' => array('filecomment' => ''), 'topic_status' => '0', 'topic_visibility' => '1', 'post_visibility' => '1'), true, true)

     (/Users/matt/Sites/repos/phpbb3-dev/phpBB/posting.php:1561)

Details

Description

Attachments

Activity

People

Dates