Currently, if the name of a style is changed in the ACP, it is not possible to install the child styles that depend on it. This is particularly problematic for prosilver, the default, non-removable style, which is the parent/ancestor of the majority of inherited styles.
Problem Description:
For style installation requirements, phpBB checks the name of the parent style based on the value of the parent key in the style.cfg file. This check depends on the style_name field stored in the database. If this name is modified from the PCA (which is possible for all styles, including prosilver), this causes an inconsistency and prevents the installation of child styles, as phpBB considers that the required parent style is not installed.
Suggested solutions:
- Disable style name modification from the PCA.
Prevent the modification of style names via the APC, or at least for prosilver on which so many styles depend. - Add a ‘decorative/passive’ style_custom_name field.
This field would return the default style name if unmodified, otherwise the one defined by the administrator in the PCA. - Ignore strict name checking.
Adapt the style installation logic so that it is based solely on the style_path of the parent style instead of its style_name in the database. (But requires a style_path key to be added to the styles .cfg)