Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-17263

Fix RTL Postbody Issue - Broken RTL Search Results Layout And RTL Topic Review Quote Button Wrong Position

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 3.3.11
    • Styles

      This bug is not minor but not exactly major, however it is important if phpBB wants to be "RTL ready" out of the box for people who use RTL languages too.

       

      I had previously posted this bug but it got mixed up with another bug because that bug needs to be fixed in order to fix this bug, with that in mind I have closed those bug tickets and this one ticket will be the fix for both bugs.

       

      Bug 1:

      When using an RTL language... if you are viewing search results and you make the screen smaller to about 912px, the postbody will break out of the layout.

       

      Bug 2:

      When using an RTL language... if you view a topic and press reply, the topic review panel at the bottom of the screen shows previous posts in the topic - but the quote button is almost in the middle of the post rather than at the end of the post.

       

      I have added LTR and RTL screen shots of both issues and used red arrows to make it clear,

       

      The Fix:

      File:

      bidi.css
      

      Find:

      .rtl .has-profile .postbody h3 {
          margin-right: 0;
          margin-left: 180px;
      }

      Add Below:

      .rtl .search .postbody {
          width: 68%;
      }

      Find:

          .rtl .postprofile, .rtl .postbody, .rtl .search .postbody {
              float: none;
          }

      Change To:

          .rtl .postprofile, .rtl .postbody, .rtl .search .postbody {
              width: auto;
              float: none;
          }

       

      Find:

          .rtl .postbody {
              margin-right: 0;
              margin-left: 16px;
          }

      Change To:

          .rtl .postbody {
              width: calc(100% - 16px - 1px - 200px);
          }

      Find:

      .rtl .topicreview {
          padding-right: 0;
          padding-left: 5px;
      }

      Add Below:

      .rtl .topicreview .postbody {
          width: auto;
          float: none;
          margin: 0;
      }

        1. LTR - Search Results.png
          20 kB
          ForumFlair
        2. LTR - Topic Review.png
          19 kB
          ForumFlair
        3. RTL - Search Results.png
          20 kB
          ForumFlair
        4. RTL - Topic Review.png
          15 kB
          ForumFlair

            Unassigned Unassigned
            ForumFlair ForumFlair
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: