Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-15592

"Place inline" button appears when BBcode is disabled (Post settings)

XMLWordPrintable

      Consider a board where BBcode is entirely disabled by the administrator, whereas the attachment is enabled. The button "Place inline" (included in the posting_attach_body.html template) is still displayed, unlike other BBcode buttons.

      The visual effect of attachment BBcode is the same as other BBcodes (no render) when BBcode is disabled. Therefore, the "Place inline" button should be hidden like other BBcode buttons.

      edit: in fact, the problem is the missing S_INLINE_ATTACHMENT_OPTIONS condition for the first iteration of the input button with {L_PLACE_INLINE} value.

        1. attachment_enabled.png
          9 kB
          Big Monstro
        2. bbcode_disabled.png
          10 kB
          Big Monstro
        3. inline_attachment_still_enabled_but_buggy.png
          39 kB
          Big Monstro

            Marc Marc
            Big Monstro Big Monstro
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: