Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-15078

Can be closed

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Invalid
    • Icon: Trivial Trivial
    • None
    • 3.2.0
    • Language pack

      The first part of the different language files in /phpBB3/languages/en/ does not all have the exact same commenting.

      In some files the "* DO NOT CHANGE" part is moved down some lines (cli.php, extenstions.php).

      In some files lines like "* This file is part of the phpBB Forum Software package." start with a space (install.php).

      Some files have "// Some characters you may want to copy&paste:" (app.php, common.php).

      Should all files perhaps have the exact same commenting in the beginning?

      Here is an example from one of the language files:

      <?php
      /**
      *
      * This file is part of the phpBB Forum Software package.
      *
      * @copyright (c) phpBB Limited <https://www.phpbb.com>
      * @license GNU General Public License, version 2 (GPL-2.0)
      *
      * For full copyright and license information, please see
      * the docs/CREDITS.txt file.
      *
      */
       
      /**
      * DO NOT CHANGE
      */
      if (!defined('IN_PHPBB'))
      {
      	exit;
      }
       
      if (empty($lang) || !is_array($lang))
      {
      	$lang = array();
      }
       
      // DEVELOPERS PLEASE NOTE
      //
      // All language files should use UTF-8 as their encoding and the files must not contain a BOM.
      //
      // Placeholders can now contain order information, e.g. instead of
      // 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
      // translators to re-order the output of data while ensuring it remains correct
      //
      // You do not need this where single placeholders are used, e.g. 'Message %d' is fine
      // equally where a string contains only two placeholders which are used to wrap text
      // in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
      //
      // Some characters you may want to copy&paste:
      // ’ » “ ” …
      //
      

            Marc Marc
            scootergrisen scootergrisen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: