Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-14901

Extension without version check should not display notice in ACP

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • 3.2.0
    • 3.2.0-RC2
    • Extensions

      Just like the extensions list in the ACP, the extension details page should not try to perform a version check if no version check information is provided. Currently a notice is displayed with two error messages and a link to Re-Check the version. (See screenshot) I believe the whole version box should be hidden in this case, because providing a version check is completely optional.

      Furthermore the error code of the exception is checked, but since 3.1 the thrown exception got replaced and therefore the getCode() will always return 0 so this can be removed as well.

      'S_VERSIONCHECK_STATUS'			=> $e->getCode(),

            nicofuma nicofuma
            Derky Derky
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: