Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-12965

Unused var $use_cache in $config->delete($key, $use_cache) function

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Invalid
    • Icon: Trivial Trivial
    • 3.1.0-RC3
    • 3.1.0-RC2
    • None
    • None

      The second parameter of the $config->delete() function: $use_cache is not used. This was probably caused by copying the $config->set() function. The doc-block has an incorrect explanation of the parameter as well.

      /phpBB/phpbb/config/config.php

      /**
      * Removes a configuration option
      *
      * @param  String $key       The configuration option's name
      * @param  bool   $use_cache Whether this variable should be cached or if it
      *                           changes too frequently to be efficiently cached
      * @return null
      */
      public function delete($key, $use_cache = true)
      {
      	unset($this->config[$key]);
      }
      

            bantu Andreas Fischer [X] (Inactive)
            Derky Derky
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: