Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-12698

Replace all instances of magic numbers with constants in javascript

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.1.3-RC1, 3.2.0-a1
    • 3.1.0-b4
    • None
    • None

      In the javascript code there are multiple instances where the so-called magic numbers are used to identify difference occurrences.
      The objective is to replace all those occurrences with "constants" in the phpBB global object.

        1.
        		 Create the base object to allocate the keyboard keys Sub-task Closed Unassigned
        2.
        		 Replace instances in the message textarea keydown callback Sub-task Unverified Fix Andreas Fischer [X] (Inactive)

            Unassigned Unassigned
            brunoais brunoais
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: