Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-12202

Variables read from style.cfg etc. should be htmlspecialchared

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.0.13-RC1, 3.1.0-b1
    • 3.0.12
    • None
    • None

      Derky pointed out that variables read from style.cfg are used in HTML as is. Now, with a malicious style, you probably have bigger problems. However, when the style name contains malicious HTML, it is persisted into the log table when installing the style which may go unnoticed by the admin.
      This can be easily prevented by htmlspecialchar()ing data that is read from the files.

        1. edit_style_xss.png
          15 kB
          Andreas Fischer [X]
        2. edit_style_xss2.png
          27 kB
          Andreas Fischer [X]

            EXreaction EXreaction [X] (Inactive)
            bantu Andreas Fischer [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: