Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-11650

INCLUDEJS output is not properly escaped

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Blocker Blocker
    • 3.1.0-a1
    • 3.1.0-dev
    • Template Engine
    • None

      The INCLUDEJS instruction does not perform HTML escaping of the generated URL, given the input:

      <!-- INCLUDEJS parent_and_child.js?test=1&assets_version=0 -->

      The output is:

      <script type="text/javascript" src=".../templates/parent_and_child.js?test=1&assets_version=0&assets_version=1"></script>

      Note the unescaped ampersands. The URL should be passed through Twigs escape filter.

            EXreaction EXreaction [X] (Inactive)
            ToonArmy Chris Smith
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: