Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-11572

Including database_update.php doesn't make sense anymore

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.1.0-a1
    • 3.1.0-dev
    • Update system
    • None

      Since schema changes are not delivered in the database_update.php anymore and a update from every 3.0.x version is supported, including database_update.php in install_update.php doesn't make any sense.

      The lines 306-324 can be removed:

      // Make sure the database update is valid for the latest version
      $valid = false;
      $updates_to_version = '';
       
      if (file_exists($phpbb_root_path . 'install/database_update.' . $phpEx))
      {
      	include_once($phpbb_root_path . 'install/database_update.' . $phpEx);
       
      	if ($updates_to_version === $this->update_info['version']['to'])
      	{
      		$valid = true;
      	}
      }
       
      // Should not happen at all
      if (!$valid)
      {
      	trigger_error($user->lang['DATABASE_UPDATE_INFO_OLD'], E_USER_ERROR);
      }

      Furthermore this would break the updater.

            nickvergessen Joas Schilling
            Elsensee Oliver Schramm [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: