Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-11453

phpbb_notification_method_email unnecessarily loads data of banned users.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2.4-RC1
    • 3.1.0-dev
    • Notification System
    • None

      First, banned user ids are fetched. Then all affected user rows are fetched and each row is checked whether the user is banned. Also, $user['user_type'] == USER_IGNORE rows are skipped.

      a) Do not fetch users who are banned from the database. An array_diff() should do.
      b) Do not fetch users with $user['user_type'] == USER_IGNORE. Either make sure such messages are never in the queue or ignore in the SQL query fetching users.

            Marc Marc
            bantu Andreas Fischer [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: