Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-11162

Get rid of $db->sql_return_on_error(true) trickery when splitting/merging topics

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.0.12-RC1
    • 3.0.11
    • None
    • None

      Background: https://github.com/phpbb/phpbb3/pull/988

      Instead of potentially doing the update that may fail, add conditions to only update rows that can be updated. The subsequent delete will take care of any left over rows.

      My expectation is that the current code does not update any rows if any of them fail on postgres and updates all rows other than failing ones on mysql.

      3.0 and 3.1 will need separate patches because of https://github.com/phpbb/phpbb3/pull/988.

            Oleg Oleg [X] (Inactive)
            Oleg Oleg [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: