incomplete conversion for large database

When upgrading to phpBB 3.0.4, the convertor would complete without error. However, only a fraction of the posts would get converted. The phpBB2 db had around 125k posts. Each time I ran the convertor, I'd only see 20k - 30k posts get processed before moving to the next table.

I suspected this was due to the max execution time. However, my forum lives on a shared server. So, increasing the time was not an option.

After some debugging, I found that $current_table was being prematurely incremented when still_on_time() was true and $counting was less than $convert->batch_size. I changed the conditional to check if $counting equalled zero. This allowed the conversion to run it's full course (with an extra iteration per table).

Since this worked for me, I didn't bother to track down the root problem.

Here's my environment details. Diff attached.

mysql 5.0.16
linux 2.4.32 SMP i686
PHP Version 5.2.6