Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-6650

Errors in RC7 -> RC8 updater

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Resolution: Fixed
    • 3.0.RC8
    • 3.0.0
    • Installation system
    • None
    • PHP Environment: 5.2.4
      Database: MySQL 5.0.45

    Description

      Guys I may be wrong BUT I think there is two bugs in upgrade script. Please please check if I am right or wrong. I know it close to the wire but I thing at the last the second bug needs addressing.

      BUG1 : Incorrect Redirect

      1) phpBB3RC7 installed for http://localhost/quickinstall/boards/phpbb3rc7/
      2) Upload RC7 -> RC8 upgrade zip
      3) Point to http://localhost/quickinstall/boards/phpbb3rc7/install/
      4) Process version check OK
      5) Process databasee update OK
      6) File check starts and and see green box with "Currently having differences about 47 from 150 files collected. Please wait until file collection finished"
      7) Redirects to http://localhost/quickinstall/install/index.php?mode=update&sub=file_check

      BUG2: Skips updating first file in update list

      First file to be updated in RC7-> RC8 is
      adm/style/acp_attachments.html

      However with the following code..

      			if (is_int($update_list['status']) && $index <= $update_list['status'])
      			{
      				continue;
      			}

      What happens on the first file is status is 0 and index for first file is also 0 so this test passes and it skips first file due to be updated.

      I really hope I am wrong but I think the two bugs above are valid.

      Attachments

        Activity

          People

            Acyd Burn Meik Sievertsen [X] (Inactive)
            poyntesm poyntesm [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: