Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-16880

Allow all BBCodes during reparsing

    XMLWordPrintable

Details

    • Improvement
    • Status: Patch Awaiting Review (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 3.3.5-RC1
    • None
    • None
    • None

    Description

      The generate_text_for_storage API allows individual BBCodes (img, flash, quote, and url) to be toggled at parsing time. However, that status isn't saved in the database. When I wrote the reparser plugins, I created a set of methods that determine whether a given BBCode or feature was enabled at parsing time based on the content of the message. Those methods can be found in phpbb\textreparser\base; They are named guess_X where X is the feature.

      When reparsing a proper text, those methods work fine as far as I can tell. However, when reparsing a text where a feature was mistakenly disabled, it makes it impossible to re-activate it (="fix it") by reparsing the text.

      As I understand now, phpBB's editor prevents messages that contain an unauthorized BBCode from being posted. If that holds true across all types of records that are processed by the reparser, it means that it should be safe to unconditionally turn on all BBCodes when reparsing instead of guessing their status based on the content.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              JoshyPHP JoshyPHP
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: