[PHPBB3-10772] trigger_error is using the default style Created: 08/Apr/12  Updated: 22/Jan/17  Resolved: 11/Jul/13

Status: Closed
Project: phpBB3
Component/s: Styles
Affects Version/s: 3.0.11
Fix Version/s: 3.0.12-RC1

Type: Bug Priority: Major
Reporter: marian0810 [X] (Inactive) Assignee: EXreaction [X] (Inactive)
Resolution: Fixed Votes: 0
Labels: None

PHP 5.2.4 and 5.3.10, MySQL 5.0.51a and MySQL 5.0.91, all browsers

GitHub Pull Request URL: https://github.com/phpbb/phpbb3/pull/1521


I created a new forum that doesn't use the default style. When browsing through the topics in that forum with the previous/next links, the trigger_error page with "There are no older/newer topics in this forum" reverts back to the default style when it should be using the style I set for that specific forum_id.

Comment by Vjacheslav Trushkin [ 11/May/13 ]

Unit tests are in separate pull request

Comment by Marc [ 12/Jul/13 ]

The PR fixes just one trigger_error() case in viewtopic.php. There are several other cases which are not covered by this patch which means it'll still display the wrong style if there is an error and a forum ID is supplied to viewtopic.php.

Comment by Vjacheslav Trushkin [ 12/Jul/13 ]

Possibly. Can you find such cases?

Comment by Marc [ 12/Jul/13 ]

Well, supplying incorrect topic IDs for example will trigger the incorrect look of trigger_error(). The question is whether we really want to fix a case like that.

Generated at Sat Feb 16 07:09:59 UTC 2019 using Jira 7.12.3#712004-sha1:5ef91d760d7124da5ebec5c16a948a4a807698df.