[PHPBB3-9701] Enable notices in unit tests Created: 02/Jul/10  Updated: 12/Jul/10  Resolved: 08/Jul/10

Status: Unverified Fix
Project: phpBB3
Component/s: None
Affects Version/s: None
Fix Version/s: 3.0.8-RC1

Type: Task Priority: Blocker
Reporter: Andreas Fischer Assignee: Nils Adermann
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Dependency
blocks PHPBB3-9714 "Undefined variable: email" in email ... Closed
Fix URL: http://github.com/naderman/phpbb3/tree/ticket/9701

 Description   

The unit tests in develop-olympus do not display notices. Notices should be enabled to make sure we don't miss anything.



 Comments   
Comment by Nils Adermann [ 08/Jul/10 ]

They are displayed just fine for me. Can you please run a test with $x[ABC] for example and see if it really doesn't show the notice?

Comment by Nils Adermann [ 08/Jul/10 ]

Well I do get the problem in that particular test. Something else must be at fault here.

Comment by Nils Adermann [ 08/Jul/10 ]

Alright finally figured out what this was caused by: When the template's display() method triggered an error / threw an exception the error level would not be reset afterwards. Added a catch clause now where it gets reset. That should work. Not an issue in 3.1 since that should have NOTICE-free templates.

Generated at Tue Dec 11 00:29:11 UTC 2018 using Jira 7.12.3#712004-sha1:5ef91d760d7124da5ebec5c16a948a4a807698df.