[PHPBB3-9581] Banned users get mass emails. Created: 30/Apr/10  Updated: 10/Apr/11  Resolved: 10/Apr/11

Status: Unverified Fix
Project: phpBB3
Component/s: Other
Affects Version/s: 3.0.7-PL1
Fix Version/s: 3.0.9-RC1

Type: Improvement Priority: Major
Reporter: stevemaury Assignee: Oleg [X] (Inactive)
Resolution: Fixed Votes: 0
Labels: None

GitHub Pull Request URL: https://github.com/phpbb/phpbb3/pull/57
Fix URL: https://github.com/phpbb/phpbb3/pull/57

 Description   

Title says it all. I don't think that is the intended behavior.



 Comments   
Comment by Adam Reyher [ 30/Apr/10 ]

I can see in certain circumstances where an admin would want to specifically email a group of banned users made by the admin, so phpBB should not hard code to prevent this behavior. If anything, an option in the ACP should be provided, with the default being set so that banned users do not get mass emails.

Comment by Oleg [X] (Inactive) [ 22/Mar/11 ]

Receiving notices with the patch:

[phpBB Debug] PHP Notice: in file /includes/acp/acp_email.php on line 142: Undefined index: user_lang
[phpBB Debug] PHP Notice: in file /includes/acp/acp_email.php on line 151: Undefined index: user_lang
[phpBB Debug] PHP Notice: in file /includes/acp/acp_email.php on line 164: Undefined index: user_lang

This is when emailing "All users". If I choose a group the notices go away.

Looks like user_lang was (accidentally?) removed from the else path in the diff.

Generated at Wed Oct 17 02:41:14 UTC 2018 using JIRA 7.9.2#79002-sha1:3bb15b68ecd99a30eb364c4c1a393359bcad6278.