Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9989

Skip PM popup in overall_header.html, if there are no new PMs.

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      n/a

      Description

      overall_header.html in prosilver has the following code:

      <!-- IF S_USER_PM_POPUP -->
      	if ({S_NEW_PM})
      	{
      		var url = '{UA_POPUP_PM}';
      		window.open(url.replace(/&amp;/g, '&'), '_phpbbprivmsg', 'height=225,resizable=yes,scrollbars=yes, width=400');
      	}
      <!-- ENDIF -->

      should be changed to:

      <!-- IF S_USER_PM_POPUP and S_NEW_PM-->
      	var url = '{UA_POPUP_PM}';
      	window.open(url.replace(/&amp;/g, '&'), '_phpbbprivmsg', 'height=225,resizable=yes,scrollbars=yes, width=400');
      	}
      <!-- ENDIF -->

      this will a save a few (precious) bytes on every page request.

        Attachments

          Activity

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              nlopes nlopes
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: