Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9978

Missing semicolons in // <![CDATA[ part of overall_header.html

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Fixed
    • 3.0.8
    • 3.0.10-RC1
    • Styles
    • None
    • phpBB 3.0.8, MySQL 5.1.34, PHP Version 5.2.14, FireFox 3.6.13, CSE HTML Validator v10.01

    Description

      Trying to track down another issue I stumbled across this. The following is extracted from rendered code. Source seems to be from Overall_header.html

      validator returns: [JavaScript] lint warning: missing semicolon
      for the beginning of the function: window.onunload = function()
      Seems to be related to the two new functions onload and onunload

      <script type="text/javascript">
      // <![CDATA[
      	var jump_page = 'Enter the page number you wish to go to:';
      	var on_page = '1';
      	var per_page = '';
      	var base_url = '';
      	var style_cookie = 'phpBBstyle';
      	var style_cookie_settings = '; path=/; domain=www2.knob.com';
      	var onload_functions = new Array();
      	var onunload_functions = new Array();
       
      	
       
      	/**
      	* Find a member
      	*/
      	function find_username(url)
      	{
      		popup(url, 760, 570, '_usersearch');
      		return false;
      	}
       
      	/**
      	* New function for handling multiple calls to window.onload and window.unload by pentapenguin
      	*/
      	window.onload = function()
      	{
      		for (var i = 0; i < onload_functions.length; i++)
      		{
      			eval(onload_functions[i]);
      		}
      	}
       
      	window.onunload = function()
      	{
      		for (var i = 0; i < onunload_functions.length; i++)
      		{
      			eval(onunload_functions[i]);
      		}
      	}
       
      // ]]>
      </script>
      

      Attachments

        Activity

          People

            Oleg Oleg [X] (Inactive)
            Ag2000CO Ag2000CO
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: