Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Labels:
      None

      Description

      The UCP and ACP create different log entries when an administrator activates an user account. If an administrator activates an user through the ACP both a `user` and `admin` log are created.

      includes/acp/acp_users.php, line:422

       
      $message = ($user_row['user_type'] == USER_INACTIVE) ? 'USER_ADMIN_ACTIVATED' : 'USER_ADMIN_DEACTIVED';
      $log = ($user_row['user_type'] == USER_INACTIVE) ? 'LOG_USER_ACTIVE' : 'LOG_USER_INACTIVE';
       
      add_log('admin', $log, $user_row['username']);
      add_log('user', $user_id, $log . '_USER');
      

      However in includes/ucp/ucp_activate.php only a log entry is created when the user re-acivates his account after a password change.

      However when admin activation is enabled the link the administrator receives points to the ucp activation module instead of the acp one. Therefore there are no logs of the user activation.

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Revised commit message.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Revised commit message.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        I need some help here.

        "However when admin activation is enabled the link the administrator receives"

        I am not seeing this link. Is it sent via email? Can it be turned on/off?

        And why does this link not go to acp?

        Show
        Oleg Oleg [X] (Inactive) added a comment - I need some help here. "However when admin activation is enabled the link the administrator receives" I am not seeing this link. Is it sent via email? Can it be turned on/off? And why does this link not go to acp?
        Hide
        Erik Frèrejean Erik Frèrejean added a comment -

        Yes its send by email.
        https://github.com/erikfrerejean/phpbb3/blob/1d2201902f0f3789daf02ca054f33f4b4bfa3eb2/phpBB/includes/ucp/ucp_register.php#L420

        Why it doesn't go to the acp? Ask Meik? , no idea but its been done through the UCP as long as I can recall.

        Show
        Erik Frèrejean Erik Frèrejean added a comment - Yes its send by email. https://github.com/erikfrerejean/phpbb3/blob/1d2201902f0f3789daf02ca054f33f4b4bfa3eb2/phpBB/includes/ucp/ucp_register.php#L420 Why it doesn't go to the acp? Ask Meik? , no idea but its been done through the UCP as long as I can recall.
        Show
        Oleg Oleg [X] (Inactive) added a comment - This patch has resulted in filing of: http://tracker.phpbb.com/browse/PHPBB3-10067 http://tracker.phpbb.com/browse/PHPBB3-10161 http://tracker.phpbb.com/browse/PHPBB3-10162 http://tracker.phpbb.com/browse/PHPBB3-10163 http://tracker.phpbb.com/browse/PHPBB3-10166

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Erik Frèrejean Erik Frèrejean
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development